Make opendb API more generic #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniy-scherbina
force-pushed
the
yevhenii/ethermint
branch
from
d75fcf4
to
8773668
Compare
evgeniy-scherbina
force-pushed
the
yevhenii/ethermint
branch
from
6eb5e23
to
461a8a9
Compare
evgeniy-scherbina
force-pushed
the
yevhenii/ethermint
branch
2 times, most recently
from
de3f081
to
a2f9efe
Compare
evgeniy-scherbina
force-pushed
the
yevhenii/ethermint
branch
from
b151dee
to
56aabfd
Compare
karzak
reviewed
Jul 2, 2024
| @@ -423,77 +428,77 @@ func registerMetrics() { | |||
| } | |||
|
|
|||
| // report reports metrics to prometheus based on rocksdb props and stats | |||
| func (m *Metrics) report(props *properties, stats *stats) { | |||
| func (m *Metrics) report(dbName string, props *properties, stats *stats) { | |||
There was a problem hiding this comment.
Is there a list/documentation of which metrics are reported? Can we link to it in Confluence?
There was a problem hiding this comment.
Best sources of information:
- grafana dashboard
- source code
- rocksdb wiki
but I'll add a README
There was a problem hiding this comment.
|
Can you also add a README for this repo @evgeniy-scherbina - can be a separate PR |
karzak
approved these changes
Jul 2, 2024
evgeniy-scherbina
force-pushed
the
yevhenii/ethermint
branch
from
496cbd2
to
3a6e771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency changes:
cosmossdk.io/api:v0.7.5->v0.3.1cometbftversion declaration:v0.38.7->v0.37.4NOTE: we're using the fork anyway:github.com/cometbft/cometbft => github.com/kava-labs/cometbft v0.37.4-kava.1golang.org/x/exp:v0.0.0-20240404231335-c0f41cb1a7a0->v0.0.0-20230711153332-06a737ee72cbNOTE: we downgraded to versions which are used in kava and ethermintSource code changes:
db nameinstead of hardcodingapplication.dbdatadb nameas a label in prometheus metricsRelated PR: Kava-Labs/ethermint#63